Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm_key doesn't import key with size > 8192 bytes #8424

Closed
lpavlicek opened this issue Aug 4, 2014 · 3 comments · Fixed by #8442
Closed

rpm_key doesn't import key with size > 8192 bytes #8424

lpavlicek opened this issue Aug 4, 2014 · 3 comments · Fixed by #8442
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release packaging Packaging category

Comments

@lpavlicek
Copy link

This doesn't work in ansible 1.6.10:

- name: install mariadb public key
  action: rpm_key state=present key=https://yum.mariadb.org/RPM-GPG-KEY-MariaDB

This key has a size of 8353 bytes. In module rpm_key is limit of 8192 bytes for download.

@ansibot
Copy link
Contributor

ansibot commented Aug 4, 2014

Thanks for filing a ticket! I am the friendly GitHub Ansibot. I see you did not fill out your issue description based on our new issue template. Please copy the contents of this template and paste it into the description of your ticket.

Our system will automatically close tickets that do not have an issue template filled out within 7 days. Please note that due to large interest in Ansible, humans may not comment on your ticket if you ask them questions. Don't worry, you're still in the queue and the robots are looking after you.

@mpdehaan
Copy link
Contributor

mpdehaan commented Aug 4, 2014

We should probably just remove the 8192 code as that doesn't seem like it needs to persist.

@Jmainguy
Copy link
Contributor

Jmainguy commented Aug 5, 2014

Since the 8192 limit was reached, I did not want to put a higher number I thought would never be reached, since that is what happened here. I removed the MAXBYTE lines and now it will try and read anything, if the key was a 2.5G file I imagine the play would hang until it completed or timed out now. That being said, a key should really not be that big.

mpdehaan added a commit that referenced this issue Aug 5, 2014
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bug_report labels Mar 6, 2018
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release packaging Packaging category
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants