Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Support ignore.txt deletions with supershipit #1239

Closed
mattclay opened this issue Jul 22, 2019 · 1 comment
Closed

Support ignore.txt deletions with supershipit #1239

mattclay opened this issue Jul 22, 2019 · 1 comment
Labels

Comments

@mattclay
Copy link
Member

PRs can be auto-merged when they contain deletions to sanity ignore files. However, it appears this feature cannot be used with supershipit privileges.

See the existing support for sanity ignore files:

elif fnmatch(thisfn, u'test/sanity/*/*.txt'):
if pr_file.additions or pr_file.status == u'added':
# new exception added, addition must be checked by an human
return create_ameta(False, u'automerge new file(s) test failed')
if pr_file.deletions:
# new exception delete
continue

Here's a PR which cannot be merged with supershipit privileges: ansible/ansible#59324

@jctanner
Copy link
Contributor

jctanner commented Sep 5, 2019

resolved by #1275

@jctanner jctanner closed this as completed Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants