New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow automerge on module PRs with tests. #808
Comments
Just raised this issue in testing meeting, seems we all are for 'automerge' working with modules + matching tests. |
|
Perhaps also corresponding rules for |
@andreaso Good point, thank you |
Note to self: Need to define a clear set of rules for this |
As part of this work we should apply any labels that the corresponding module (or plugin/module_util would have added. ie
This also means that the shipit/merge rules for the code itself apply to the test code |
See also #811 |
Currently it seems that some module-only PRs with accompanied tests can't be automerged: ansible/ansible#44789 (comment) (I later modified the PR and added some changelog fragment, which is known to block automerge anyway currently... But at the time of that |
blocking module automerges because of updated tests, bites me again. |
ansible/ansible#31607
This is definitely necessary if we are demanding new tests with every PR.
The text was updated successfully, but these errors were encountered: