Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow automerge on module PRs with tests. #808

Open
jctanner opened this issue Oct 31, 2017 · 9 comments
Open

allow automerge on module PRs with tests. #808

jctanner opened this issue Oct 31, 2017 · 9 comments

Comments

@jctanner
Copy link
Contributor

jctanner commented Oct 31, 2017

ansible/ansible#31607

This is definitely necessary if we are demanding new tests with every PR.

@bcoca
Copy link
Member

bcoca commented Aug 2, 2018

Just raised this issue in testing meeting, seems we all are for 'automerge' working with modules + matching tests.

@gundalow
Copy link
Collaborator

gundalow commented Aug 2, 2018

  • Only if test/integration/target/$modulename/ (not just anything with label:test, for example we don't want automerge on changes to test/runner)
  • Should also apply to test/units//$modulename/

@andreaso
Copy link

andreaso commented Aug 13, 2018

Perhaps also corresponding rules for ./test/legacy/?

@gundalow
Copy link
Collaborator

@andreaso Good point, thank you

@gundalow
Copy link
Collaborator

Note to self: Need to define a clear set of rules for this

@gundalow
Copy link
Collaborator

gundalow commented Sep 10, 2018

As part of this work we should apply any labels that the corresponding module (or plugin/module_util would have added.

ie

  1. change to test/integration/target/nxos_command should result with:
  • label networking as modules/network/nxos/nxos_command's BOTMETA has label:networking
  • Notify $team_nxos, again via BOTMETA entry for the module
  • support:network, again via BOTMETA entry for the module
  1. Same for test/legacy/roles/{module}

  2. Same for test/units/modules/

  3. change to test/units/plugins/httpapi/
    Match BOTMETA for lib/ansible/plugins/connection/httpapi.py

  • support: network
  • label: network
  • maintainers: $team_networking

This also means that the shipit/merge rules for the code itself apply to the test code

@gundalow
Copy link
Collaborator

See also #811

@felixfontein
Copy link
Contributor

Currently it seems that some module-only PRs with accompanied tests can't be automerged: ansible/ansible#44789 (comment)

(I later modified the PR and added some changelog fragment, which is known to block automerge anyway currently... But at the time of that bot_status comment, all conditions for automerge were fulfilled IMO.)

@gundalow gundalow moved this from Next to Medium in Contributor Experience Nov 8, 2018
@resmo
Copy link
Contributor

resmo commented Jan 9, 2019

blocking module automerges because of updated tests, bites me again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bot Work
  
To do
Development

No branches or pull requests

6 participants