Project delete-on-update option may not be working correctly

[AlanCoding]

ISSUE TYPE

• Bug Report

SUMMARY

This output should probably never be allowed to happen:

If the deletion was successful, then the git task should always be changed. Instead, it is "ok" - no change.

I suspect this is because the deletion task may not be deleting hidden folders, including the .git folder, which the git module detects, so it then does a checkout, as opposed to a new clone. This is not the intention. The folder should be genuinely empty after the deletion task.

[WebSpider]

You seem to be correct, sir.

awx/awx/playbooks/project_update.yml

Line 28 in fb7c827

command: "rm -rf {{project_path}}/*" # volume mounted, cannot delete folder itself

does not seem to remove hidden files and/or directories

[sarabrajsingh]

@AlanCoding - ran integration tests and they were a-ok.

[CFSNM]

Using latest devel awx:

PLAY [Update source tree if necessary] *****************************************
    
TASK [delete project directory before update] **********************************
changed: [localhost]
    
TASK [update project using git] ************************************************
ok: [localhost]

TASK [Set the git repository version] ******************************************
ok: [localhost]

TASK [Repository Version] ******************************************************
ok: [localhost] => {
 "msg": "Repository Version 98b8dc2d4d6671ddceab73a5d3958e94fcdba419"
 }

PLAY [Install content with ansible-galaxy command if necessary] ****************

TASK [debug] *******************************************************************
ok: [localhost] => {
"msg": "Collection and role syncing disabled. Check the AWX_ROLES_ENABLED and AWX_COLLECTIONS_ENABLED settings and Galaxy credentials on the project's organization.\\n"

TASK [meta] ********************************************************************

PLAY RECAP *********************************************************************
localhost                  : ok=5    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

The task is still showing Ok as result

[sarabrajsingh]

@CFSNM i just introduced a new fix with #12205 - can you retest again please?

[CFSNM]

Using last devel kit:

PLAY [Update source tree if necessary] *****************************************
  
  TASK [delete project directory before update] **********************************
  changed: [localhost]
  
  TASK [update project using git] ************************************************
  changed: [localhost]
  
  TASK [Set the git repository version] ******************************************
  ok: [localhost]
  
  TASK [Repository Version] ******************************************************
  ok: [localhost] => {
      "msg": "Repository Version 98b8dc2d4d6671ddceab73a5d3958e94fcdba419"
  }
  
  PLAY [Install content with ansible-galaxy command if necessary] ****************
  
  TASK [debug] *******************************************************************
  ok: [localhost] => {
      "msg": "Collection and role syncing disabled. Check the AWX_ROLES_ENABLED and AWX_COLLECTIONS_ENABLED settings and Galaxy credentials on the project's organization.\\n"
  }
  
  TASK [meta] ********************************************************************
  
  PLAY RECAP *********************************************************************
  localhost                  : ok=5    changed=2    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

Closing this issue