Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unformatted help text is popped out when peers for intances are changed #14924

Closed
5 of 11 tasks
kurokobo opened this issue Feb 26, 2024 · 7 comments
Closed
5 of 11 tasks

Comments

@kurokobo
Copy link
Contributor

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.
  • I am NOT reporting a (potential) security vulnerability. (These should be emailed to security@ansible.com instead.)

Bug Summary

Following unformatted help text (includes {0} and {1}) is popped out on the top-right corner when I change peers for any intances.

Peers update on {0}. Please be sure to run the install bundle for {1} again in order to see changes take effect.

image

AWX version

23.8.1

Select the relevant components

  • UI
  • UI (tech preview)
  • API
  • Docs
  • Collection
  • CLI
  • Other

Installation method

kubernetes

Modifications

no

Ansible version

N/A

Operating system

CentOS Stream 8

Web browser

Chrome

Steps to reproduce

Unformatted help text will be popped out on the steps 4 and 5.

  1. Add hop01.example.com as new hop node
  2. Add exec01.example.com as new execution node, with port 27199
  3. Open hop01.example.com and move on to the Peers tab
  4. Associate exec01.example.com as a peer
  5. Remove exec01.example.com from peers

Expected results

The help text should be

Peers update on hop01.example.com. Please be sure to run the install bundle for hop01.example.com again in order to see changes take effect.

Actual results

Help text contains {0} and {1}.

Peers update on {0}. Please be sure to run the install bundle for {1} again in order to see changes take effect.

Additional information

No response

@thedoubl3j
Copy link
Member

@jbradberry
Copy link
Contributor

@jbradberry
Copy link
Contributor

There is another similar format string in there, raising the question whether that one is broken as well.

@jbradberry
Copy link
Contributor

cc @dmzoneill

@kurokobo
Copy link
Contributor Author

kurokobo commented Mar 5, 2024

Maybe Lingui related issue I guess

@dmzoneill dmzoneill self-assigned this Mar 13, 2024
@dmzoneill
Copy link
Member

#14990

@jbradberry
Copy link
Contributor

#14990 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants