Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefiles should perhaps be renamed to GNUMakefile #47

Closed
swills opened this issue Sep 7, 2017 · 1 comment
Closed

Makefiles should perhaps be renamed to GNUMakefile #47

swills opened this issue Sep 7, 2017 · 1 comment

Comments

@swills
Copy link
Contributor

swills commented Sep 7, 2017

Summary

The Makefile's included with the project are not compatible with non-GNU versions of make(1). Therefore, according to the GNU Make docs, they should be called GNUMakefile:

https://www.gnu.org/software/make/manual/make.html#Makefile-Names

The first name checked, GNUmakefile, is not recommended for most makefiles. You should use this name if you have a makefile that is specific to GNU make, and will not be understood by other versions of make. Other make programs look for makefile and Makefile, but not GNUmakefile.

Environment

  • AWX version: devel
  • Ansible version: 2.3.2.0
  • Operating System: FreeBSD
  • Web Browser: Firefox

Steps To Reproduce:

Try to run the install playbook.

Expected Results:

Correct build

Actual Results:

make: ".../awx/Makefile" line 35: Missing dependency operator

Additional Information:

Calling gmake instead of make avoids the issue, but perhaps renaming is a better solution. Up to you.

@ryanpetrello
Copy link
Contributor

Closing due to age and low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants