Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a workflow approvals list #8373

Closed
mabashian opened this issue Oct 12, 2020 · 1 comment
Closed

Add a workflow approvals list #8373

mabashian opened this issue Oct 12, 2020 · 1 comment
Assignees
@mabashian
Labels
type:feature prioritized on a feature board
Projects
AWX PF

Comments

@mabashian
Copy link
Member

ISSUE TYPE
  • Feature Idea
SUMMARY

API gives us /api/v2/workflow_approvals just like many other lists. We can use this to build our familiar list + details pattern alongside #7112.

Additionally, we can use this as the interface for approving/denying workflow approvals rather than having a one-off drawer.

This list should feature the following things:

  1. Show the workflow approval name along with a link to the approval details view
  2. Show the job name along with a link to the job that contains this workflow approval
  3. The status of the approval if !pending
  4. If/When the approval expires
  5. Buttons to approve/deny the approval when rbac permits
  6. Button to delete the approval when rbac permits
@mabashian mabashian added state:needs_devel type:feature prioritized on a feature board labels Oct 12, 2020
@mabashian mabashian self-assigned this Oct 12, 2020
@mabashian mabashian added this to Backlog in AWX PF via automation Oct 12, 2020
@mabashian mabashian moved this from Backlog to Ready For Development in AWX PF Oct 12, 2020
This was referenced Oct 12, 2020
Closed
Merged
@mabashian mabashian moved this from Ready For Development to In Progress in AWX PF Nov 20, 2020
@tiagodread
Copy link
Contributor

Closing this after merging #8375 tests already merged.

AWX PF automation moved this from In Progress to Closed Nov 27, 2020
This was referenced Jan 4, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mabashian mabashian

Labels
type:feature prioritized on a feature board
Projects
No open projects
AWX PF
  
Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mabashian @tiagodread