Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Travis badge reports failures on non-master branch #242

Closed
kulinacs opened this issue Mar 16, 2017 · 1 comment
Closed

Travis badge reports failures on non-master branch #242

kulinacs opened this issue Mar 16, 2017 · 1 comment

Comments

@kulinacs
Copy link

kulinacs commented Mar 16, 2017

Currently, a failed build on Travis marks the TravisCI badge as failing, whether it is on master or not.

It seems the bug may lie in:
https://github.com/ansible/galaxy/blob/master/galaxy/api/views.py#L873

TravisCI does not currently allow reporting on specific branches, but includes the built branch in the notification. Instead of setting the branch solely based on the notification received, there should likely be a comparison with the branch specified by the role (or the default used in import) to check if the status should be changed (and which status badge should be used)

@chouseknecht
Copy link
Contributor

This issue was moved to ansible/galaxy#67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants