Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec.pulp_settings.GALAXY_FEATURE_FLAGS.execution_environments wrong type #85

Open
Svenum opened this issue Mar 14, 2024 · 1 comment
Open

Comments

@Svenum
Copy link

Svenum commented Mar 14, 2024

Describe the bug
spec.pulp_settings.GALAXY_FEATURE_FLAGS.execution_environments in the CRD galaxy has the wrong type. If I set it to false I get the error "value false not known. Did you mean: "False""
So it must be of type string and written like "True" or "False".

To Reproduce
Deploy:

---
apiVersion: galaxy.ansible.com/v1beta1
kind: Galaxy
metadata:
  name: galaxy
  namespace: galaxy
spec:
  hostname: galaxy-kube.example.com
  ingress_type: ingress
  storage_type: File
  file_storage_access_mode: ReadWriteOnce
  file_storage_size: 8Gi
  no_log: false
  api:
    replicas: 2
  content:
    replicas: 2
  web:
    replicas: 2
  worker:
    replicas: 2
  postgres_configuration_secret: galaxy-postgres-configuration
  pulp_settings:
    GALAXY_FEATURE_FLAGS:
        execution_environments: false
    GALAXY_ENABLE_UNAUTHENTICATED_COLLECTION_ACCESS: "True"
    GALAXY_ENABLE_UNAUTHENTICATED_COLLECTION_DOWNLOAD: "True"

Expected behavior
EEs should be disabled.

@Denney-tech
Copy link

Yep, incorrect casing is applied to booleans. Should be Pascal case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants