Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop cookiecutter from molecule #3486

Closed
ssbarnea opened this issue Mar 31, 2022 · 4 comments
Closed

Drop cookiecutter from molecule #3486

ssbarnea opened this issue Mar 31, 2022 · 4 comments
Labels
Milestone

Comments

@ssbarnea
Copy link
Member

As the future of cookiecutter project seems to be not sure I would like to propose dropping it before it becomes a real issue, even a security one (yep current release 1.7.3 from pypi being affected by one command injection security issue).

I personally reached a point where I am ok with any of the following approaches:

  • use either ansible playbooks for templating
  • removal of init functionality (templating)

I am fully aware that some people might like this but I do not think that the maintenance burden justifies keeping that feature, especially as its interaction with molecule provisioner plugins makes it even more problematic to use and debug.

As this is likely to count as a major change, it should be planned for v4 which is already on main branch. If anyone is interesting in helping with this task, please let me know.

References

@ssbarnea ssbarnea added the bug label Mar 31, 2022
@ssbarnea ssbarnea added this to the 4.0.0 milestone Mar 31, 2022
@zhan9san
Copy link
Contributor

i'd like to have a try

@ssbarnea
Copy link
Member Author

Super! Basically I would look into using ansible itself to do the templating, or jinja2. Keep in mind that we do also have plugins that add their own templates.

As it would be a breaking change it, we could expect to need to update the plugins and/or templates, but the goal is to minimize the amount of change if possible.

@jensens
Copy link

jensens commented May 30, 2022

Cookiecutter is live again - we released 2.1.0 https://pypi.org/project/cookiecutter/2.1.0/

@ssbarnea
Copy link
Member Author

ssbarnea commented Jun 1, 2022

Closed as not needed anymore.

@ssbarnea ssbarnea closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants