Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule login crash on iTerm2 resize window #545

Closed
chrisb3ll opened this issue Oct 7, 2016 · 11 comments
Closed

Molecule login crash on iTerm2 resize window #545

chrisb3ll opened this issue Oct 7, 2016 · 11 comments

Comments

@chrisb3ll
Copy link

chrisb3ll commented Oct 7, 2016

When using moelcule login to ssh into a test instance, any action to resize the shell window in iTerm2 results in the error below and exits the test instance.

Not a big deal, just a minor inconvenience.
Please let me know if there is anything I can do to help.

vagrant@test-logstash1:~$ Traceback (most recent call last):
  File "/usr/local/bin/molecule", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/molecule/cli.py", line 68, in main
    CLI().main()
  File "/usr/local/lib/python2.7/site-packages/molecule/cli.py", line 64, in main
    util.sysexit(c.execute()[0])
  File "/usr/local/lib/python2.7/site-packages/molecule/command/login.py", line 114, in execute
    self.molecule._pt.interact()
  File "/usr/local/lib/python2.7/site-packages/pexpect/pty_spawn.py", line 745, in interact
    self.__interact_copy(escape_character, input_filter, output_filter)
  File "/usr/local/lib/python2.7/site-packages/pexpect/pty_spawn.py", line 770, in __interact_copy
    r, w, e = select_ignore_interrupts([self.child_fd, self.STDIN_FILENO], [], [])
  File "/usr/local/lib/python2.7/site-packages/pexpect/utils.py", line 138, in select_ignore_interrupts
    return select.select(iwtd, owtd, ewtd, timeout)
  File "/usr/local/lib/python2.7/site-packages/molecule/command/login.py", line 124, in _sigwinch_passthrough
    self._pt.setwinsize(a[0], a[1])
AttributeError: 'Login' object has no attribute '_pt'
@lxhunter
Copy link

lxhunter commented Oct 7, 2016

+1

@retr0h
Copy link
Contributor

retr0h commented Oct 8, 2016

I know this is an issue. @abrown-sg brought this up a the other day. However, I cannot duplicate it. Can you tell me what to do? I have fired up an instance, logged in via molecule login and am resizing my iterm2 window.

I am inside a tmux tho... :/

vagrant@group-vars-scenario:~$ echo $TERM
screen-256color

@lxhunter
Copy link

lxhunter commented Oct 8, 2016

I will make a Video

Am 08.10.2016 um 05:22 schrieb John Dewey notifications@github.com:

I know this is an issue, @abrown-sg brought this up a while back. However, I cannot duplicate it. Can you tell me what to do? I have fired up an instance, logged in via molecule login and am resizing my iterm2 window.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@retr0h
Copy link
Contributor

retr0h commented Oct 8, 2016

Sweet 👌

@lxhunter
Copy link

lxhunter commented Oct 8, 2016

hey retr0h,

here it is: https://dl.dropboxusercontent.com/u/16675326/molecule_crash.mov

(sorry, forgot to compress)

If you need to know more about my shell: https://github.com/lxhunter/dotfiles

otherwise shout ;)

Thanks!

@retr0h
Copy link
Contributor

retr0h commented Oct 8, 2016

hi @lxhunter the video doesn't really show how you resized the window. Do you type a key combo? When I drag the window with my mouse, I cannot reproduce. Any additional info you have would be helpful.

@lxhunter
Copy link

lxhunter commented Oct 8, 2016

Hey John,

the "pill" on the lower right side lights up a little as I drag with the mouse. I can redo it tomorrow. I use iTerm 2 if that help.

Will look for further info.

Cheers

@chrisb3ll
Copy link
Author

Hi @retr0h - apologies, I just upgraded to 1.12.4 (from 1.11.4) and its fixed.

@retr0h
Copy link
Contributor

retr0h commented Oct 9, 2016

@chrisb3ll @lxhunter Looks like this was fixed inadvertently during a coverage test PR.

@retr0h retr0h added the question label Oct 9, 2016
@retr0h
Copy link
Contributor

retr0h commented Oct 10, 2016

@lxhunter can you confirm against 1.12 series?

@lxhunter
Copy link

confirmed! Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants