Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open collection" should open in new window, with a new virtual environment #1287

Closed
cidrblock opened this issue Apr 29, 2024 · 0 comments · Fixed by #1296
Closed

"Open collection" should open in new window, with a new virtual environment #1287

cidrblock opened this issue Apr 29, 2024 · 0 comments · Fixed by #1296

Comments

@cidrblock
Copy link

When a collection is installed in editable mode:

We should build a new virtual environment for that project in that project
The collection should be installed in that venv
A new window should open for that project

It's a little funky right now because the collection is installed in the current venv which may be in a different project and the new opens in the current window. This crosses the line between projects and doesn't follow the 1 window, 1 workspace, 1 repo way of doing things.

ade should be able to do it all with a --venv venv param and possible --system-site-packages

We made need to talk more about how the tool chain get installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant