Add dev plan #1
Merged
Add dev plan #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't merge this just yet, still testing. Will report back when I've finished. |
djzager
commented
Sep 27, 2017
| test: false | ||
| triggers: | ||
| - type: ConfigChange | ||
| triggers: |
There was a problem hiding this comment.
Unindented this because I am pretty sure it doesn't belong under volumes.
dymurray
reviewed
Sep 27, 2017
Dockerfile
Outdated
| @@ -3,32 +3,36 @@ MAINTAINER Ansible Playbook Bundle Community | |||
|
|
|||
| LABEL "com.redhat.apb.version"="0.1.0" | |||
djzager
force-pushed
the
add-dev-plan
branch
from
3e6874d
to
303ba52
Compare
dymurray
reviewed
Sep 27, 2017
| k8s_v1_service: | ||
| name: "{{ service_name }}" | ||
| namespace: '{{ namespace }}' | ||
| state: present |
There was a problem hiding this comment.
This will never get deprovisioned. Need "{{ state }}"
|
So I tested this by pushing to my |
|
Started an origin 3.6 cluster with catasb and:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.