-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This APB should consume kubevirt.yaml release #2
Comments
Correct me if I'm wrong @karmab, but @karmab used his project https://github.com/karmab/ttapb to generate the playbooks from https://github.com/kubevirt/kubevirt/blob/master/manifests/release/kubevirt.yaml.in. With this tool, we could regenerate the playbooks on a per commit basis to |
@rthallisey if it is like this, then I don't have problem with it. Just note: I think it should be generated from released manifest, no? For example: https://github.com/kubevirt/kubevirt/releases/download/v0.2.0/kubevirt.yaml instead of |
@lukas-bednar I think that makes sense when we tag a release for the apb so we're right in sync with kubevirt release. But during the development cycle, I think we want to pull from the latest templates so developers will always have the latest bits. |
indeed the idea is to use the tooling to generate the playbook from the release file ( this is what i did and now i updated the tool to also allow prior rendering of template ) |
This repository contains static templates which are the kubevirt.yaml itself just broken down into separated files one per each kind. I am talking about templates located under following directory.
https://github.com/ansibleplaybookbundle/kubevirt-apb/tree/master/roles/kubevirt-apb/templates
In my opinion this APB is supposed to consume kubevirt.yaml which is part of KubeVirt release.
https://github.com/kubevirt/kubevirt/releases
The text was updated successfully, but these errors were encountered: