Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code doesn't build properly #10

Closed
paulmolluzzo opened this issue Sep 5, 2017 · 1 comment
Closed

VS Code doesn't build properly #10

paulmolluzzo opened this issue Sep 5, 2017 · 1 comment

Comments

@paulmolluzzo
Copy link
Collaborator

#7, and specifically cba15ac, introduced a bug for the build of the VS Code version. The build is now importing a common css-in-js-helpers package but it's not being transpiled through babel, throwing errors in the resulting build:

Activating extension `paulmolluzzo.convert-css-in-js` failed:  Unexpected token export
Here is the error stack:  /Users/molluzzp/css-in-js-package/packages/vscode-css-in-js/node_modules/css-in-js-helpers/index.js:28
export default function convert(s) {
^^^^^^
SyntaxError: Unexpected token export

The two possible solutions are:
1 - symlink the relevant files into the VS Code version and import them directly.
2 - include a transpilation/build step into the css-in-js-helpers package.

I'm inclined to go with the second option. @ansumanshah any thoughts or preferences?

@ansumanshah
Copy link
Owner

oops we have to transpile that package with babel yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants