-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle pre-release versions in the doc actions #217
Comments
Ping @jorgepiloto @Revathyvenugopal162 @RobPasMue for visibility. Note: this is not an urgent feature request. The PyPI publishing part of the release action works for pre-releases. |
Yes, this would definitely be a nice-to-have. Thanks for posting the issue @greschd! |
Thanks for suggesting this, @greschd. The actions fail because no wheelhouse artifacts got generated. Just add the pyansys/actions/build-wheelhouse@v4 action. Regarding multi-version for versions with suffix, this feature seems very interesting. I bet we can implement it in the actions. |
@jorgepiloto do I understand it correctly that we'll also need to add this for the full release (not pre-release) pipeline to run successfully? |
That's right, @greschd. The release-github@v4 action assumes that you have generated the following artifacts:
|
Similarly it would be nice if it supported the "post" prefix in tags. I've tried to release a version 1.0.0.post0, to fix minor issues in documentation, but that's currently blocked in the docs-deploy action |
We had a short discussion about this issue. The logic for handling pre-releases would be as follow:
|
Yep let's go with that approach! |
This issue is more complicated than what I expected. However, it is a desired feature. I do not want to block new features that we want to implement in the incoming days. To protect the integrity of version 4.1, I am going to attach this issue to 4.2. This way, we can release 4.1 with simple features that are required, like #294. |
As an unblocker for this, which remains a problem for us: can we just get the docs-deploy-stable action to ignore pre-release versions of packages? That doesn't address the issue with post releases, but does mean that at least three sets of perfectly valid semantic versioning tags will work as "expected"? We need to make use of alpha and beta tags as our openapi packages are built during API development for testing purposes, and this issue blocks either our publishing of builds, or our use of the documentation deployment action. The former is unsustainable, the latter is inconvenient. |
@ansys/pyansys-core - we should work on this sooner rather than later. This has been going for too long. Many projects benefit from the usage of pre/post release tags - it'd be great to publish those docs. Pinging @greschd since we just spoke about it |
馃摑 Description of the feature
Currently, deploying a pre-release version (e.g.
0.3b1
) fails, see e.g. this pipeline run: https://github.com/pyansys/pydpf-composites/actions/runs/4565823726/jobs/8057628442 [1]When deploying the documentation for a pre-release version, we should consider that the logic needs to be somewhat different:
versions/stable
should not be updated to point to the new pre-release(stable)
; maybe marked as(pre-release)
instead0.2.1
, and then a0.2.2b1
).[1] Note that it's the "release to Github" step that fails, not docs. I think the special logic would mainly have to be in the docs, though.
馃挕 Steps for implementing the feature
No response
馃敆 Useful links and references
No response
The text was updated successfully, but these errors were encountered: