-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action for doc-build
on Windows
#319
Comments
doc-build
action only works on UNIX envs. We do have a workflow [here](https://github.com/ansys/pygeometry/blob/main/.github/workflows/ci_cd.yml#L186) that builds it on Windows. I'd like to adapt the actions to also allow Windows builds. Let me work on that. Creating an issue on ansys/actionsdoc-build
on Windows
Ideally, the workflow should run also under a Windows machine. That is why the "shell" keyword is required. Even though it reads "bash", GitHub takes care of converting Linux commands to Windows ones. The only thing that could break the compatibility of the action is a non cross-platform command, like the "xvfb-run". If that is the case, we may have to revisit the action implementation for non-screen mode. |
I'm not so sure about that... the "make" commands are not available by default on Windows. You have to actively run the .bat scripts we have. |
Following this issue, I'll open a PR where doc-build action redirects to |
Thanks @SMoraisAnsys - ping me if you need anything! |
Hi @SMoraisAnsys - any updates here? |
@RobPasMue Unfortunately I had to focus on other things... However I've "free time" this week and planned to focus on it ! |
Awesome! Looking forward to it. Ping me in case of doubts or for PR review! :) |
The
doc-build
action only works on UNIX envs. We do have a workflow here that builds it on Windows. I'd like to adapt the actions to also allow Windows builds. Let me work on that. Creating an issue on ansys/actionsOriginally posted by @RobPasMue in ansys/pymechanical#243 (comment)
The text was updated successfully, but these errors were encountered: