Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop if pre-commit fixes changelog fragment file #436

Closed
2 tasks done
klmcadams opened this issue Mar 29, 2024 · 1 comment 路 Fixed by #437
Closed
2 tasks done

Infinite loop if pre-commit fixes changelog fragment file #436

klmcadams opened this issue Mar 29, 2024 · 1 comment 路 Fixed by #437
Assignees
Labels
bug Something isn't working

Comments

@klmcadams
Copy link
Contributor

klmcadams commented Mar 29, 2024

馃攳 Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

馃悶 Description of the bug

There was a trailing whitespace in a changelog fragment file, so pre-commit fixed it, which caused the doc-changelog action to think that its fragment file was modified so it replaced it with the title containing the trailing whitespace. This continued a bunch of times

馃摑 Steps to reproduce

Create a PR with a trailing whitespace in a repo that has doc-changelog and pre-commit.ci set up

Links:
https://github.com/ansys/pymechanical/actions/runs/8474078508/job/23219758431
ansys/pymechanical#666

馃捇 Which operating system are you using?

Linux

馃搥 Which ANSYS version are you using?

N/A

馃悕 Which Python version are you using?

3.9

馃摝 Installed packages

N/A
@klmcadams klmcadams added the bug Something isn't working label Mar 29, 2024
@klmcadams klmcadams self-assigned this Mar 29, 2024
@MaxJPRey
Copy link
Contributor

Nice catch @klmcadams .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants