Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make row indices unique when importing csv studies #365

Merged
merged 5 commits into from
May 15, 2024

Conversation

safeerehman
Copy link
Collaborator

closes #364

-reset indices after concatenating the individual simulation types In the ParametricStudy::_remove_duplicate_entries() method.

@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (65cc351) to head (951a5b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          30       30           
  Lines        3051     3055    +4     
=======================================
+ Hits         3003     3007    +4     
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@safeerehman safeerehman force-pushed the fix/364-imported-csv-row-indices branch from 55046d2 to 42ae199 Compare May 14, 2024 20:40
@safeerehman safeerehman changed the base branch from main to release/0.18 May 14, 2024 20:53
@safeerehman safeerehman changed the base branch from release/0.18 to main May 14, 2024 21:55
Copy link
Collaborator

@pkrull-ansys pkrull-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

CHANGELOG.md Outdated Show resolved Hide resolved
@safeerehman safeerehman merged commit 5be87ab into main May 15, 2024
32 checks passed
@safeerehman safeerehman deleted the fix/364-imported-csv-row-indices branch May 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyadditive parametric study writes microstructure results to previous single bead and porosity studies
3 participants