Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: kwargs #4672

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

REFACTOR: kwargs #4672

wants to merge 33 commits into from

Conversation

gmalinve
Copy link
Collaborator

refactoring kwargs maxwellcircuit.py, CableModeling.py, report_templates.py, general_methods.py

@gmalinve gmalinve self-assigned this May 14, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue May 14, 2024 that may be closed by this pull request
Arguments deprecation #4420
Open
32 tasks
@gmalinve gmalinve added this to the v1.0 milestone May 14, 2024
@github-actions github-actions bot added the examples Anything related to the examples label May 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024 •
edited by codecov bot

Codecov Report

Attention: Patch coverage is 85.02538% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 80.13%. Comparing base (793b53d) to head (4f12e65).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4672      +/-   ##
==========================================
- Coverage   80.23%   80.13%   -0.11%     
==========================================
  Files         123      123              
  Lines       55259    55280      +21     
==========================================
- Hits        44338    44299      -39     
- Misses      10921    10981      +60

@gmalinve gmalinve changed the title refactoring kwargs REFACTOR: kwargs May 14, 2024
maxcapodi78
maxcapodi78 requested changes May 15, 2024
View reviewed changes
_unittest/test_02_2D_modeler.py Show resolved Hide resolved
examples/03-Maxwell/Maxwell_Transformer_Coreloss.py Outdated Show resolved Hide resolved
pyaedt/generic/general_methods.py Outdated Show resolved Hide resolved
SMoraisAnsys
SMoraisAnsys previously approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring ! I left minor comments

_unittest/test_12_PostProcessing.py Outdated Show resolved Hide resolved
examples/02-HFSS/HFSS_Choke.py Outdated Show resolved Hide resolved
pyaedt/application/analysis_hf.py Outdated Show resolved Hide resolved
pyaedt/generic/general_methods.py Outdated Show resolved Hide resolved
@gmalinve gmalinve marked this pull request as draft May 17, 2024 14:59
@SMoraisAnsys SMoraisAnsys mentioned this pull request May 21, 2024
Closed
@gmalinve
Merge branch 'main' into refacto_kwargs
64d46a4
@gmalinve
Merge branch 'main' into refacto_kwargs
4f12e65 
# Conflicts:
#	pyaedt/generic/general_methods.py
#	pyaedt/modules/solutions.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcapodi78 maxcapodi78 maxcapodi78 requested changes

@MaxJPRey MaxJPRey MaxJPRey left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@dcrawforAtAnsys dcrawforAtAnsys Awaiting requested review from dcrawforAtAnsys

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

Requested changes must be addressed to merge this pull request.

Assignees

@gmalinve gmalinve

Labels
examples Anything related to the examples
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Arguments deprecation
6 participants
@gmalinve @codecov-commenter @maxcapodi78 @Samuelopez-ansys @MaxJPRey @SMoraisAnsys