-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adding plotting support or not #136
Comments
The ansys-tools-report tool package will require PyVista in any case (as a dependency) so... not sure if we can do this. |
I do not like having pyvista as a dependency... but I think that kind of information is useful. We could do a I would also advocate to extract the code for that check from pyvista. |
pyvista is a dependency of the package for the GPU check we perform... and we also use scooby which is our main dependency, which also uses pyvista as a dep... so it's going to be almost impossible to "not have" pyvista as a dependency for this package. |
Ohh.. I misunderstood your comment. In that case including a line in the report that says:
should be pretty straight forward because pyvista is already a dependency :) |
My point is that it will always return |
Oohh..... you are right. Having pyvista equals plot support. My bad. |
No no.. wait. My bad again. It is two different things; having pyvista and having plotting support. For instance we have this PyMAPDL: which shows for the smoke tests: Plotting support is either a physical display, or having a display buffer ( |
Oh got it... this is something different then. |
I think the report should include something like:
This can be done with pyvista. Not sure if we want to have such dependency. We should always, extract that part from the library.
The text was updated successfully, but these errors were encountered: