Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding plotting support or not #136

Closed
germa89 opened this issue Oct 9, 2023 · 8 comments
Closed

Feat: Adding plotting support or not #136

germa89 opened this issue Oct 9, 2023 · 8 comments

Comments

@germa89
Copy link
Contributor

germa89 commented Oct 9, 2023

I think the report should include something like:

Plotting support; True/False

This can be done with pyvista. Not sure if we want to have such dependency. We should always, extract that part from the library.

@RobPasMue
Copy link
Member

The ansys-tools-report tool package will require PyVista in any case (as a dependency) so... not sure if we can do this.

@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

I do not like having pyvista as a dependency... but I think that kind of information is useful.

We could do a try on import pyvista and if successful, just show that line or not.

I would also advocate to extract the code for that check from pyvista.

@RobPasMue
Copy link
Member

pyvista is a dependency of the package for the GPU check we perform... and we also use scooby which is our main dependency, which also uses pyvista as a dep... so it's going to be almost impossible to "not have" pyvista as a dependency for this package.

@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

Ohh.. I misunderstood your comment.

In that case including a line in the report that says:

Plotting support; True/False

should be pretty straight forward because pyvista is already a dependency :)

@RobPasMue
Copy link
Member

My point is that it will always return True because it will always be a dependency of the ansys-tools-report package...

@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

Oohh..... you are right. Having pyvista equals plot support. My bad.

@germa89 germa89 closed this as completed Oct 16, 2023
@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

No no.. wait. My bad again.

It is two different things; having pyvista and having plotting support.

For instance we have this PyMAPDL:
https://github.com/ansys/pymapdl/blob/5040f1270c1b531723c326bffa36bf95b6f90723/.github/workflows/ci.yml#L98

which shows for the smoke tests:
https://github.com/ansys/pymapdl/actions/runs/6532426663/job/17735570170#step:4:43

Plotting support is either a physical display, or having a display buffer (xvfb). So I still think this is useful.

@germa89 germa89 reopened this Oct 16, 2023
@RobPasMue
Copy link
Member

Oh got it... this is something different then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants