Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential file transfer discrepancy #2817

Closed
seanpearsonuk opened this issue May 14, 2024 · 1 comment · Fixed by #2823
Closed

Potential file transfer discrepancy #2817

seanpearsonuk opened this issue May 14, 2024 · 1 comment · Fixed by #2823
Assignees
Labels
question Further information is requested

Comments

@seanpearsonuk
Copy link
Collaborator

In container_launcher.py:

        fluent_connection = FluentConnection(

            port=port,

            password=password,

            file_transfer_service=self.file_transfer_service,

            cleanup_on_exit=self.cleanup_on_exit,

            slurm_job_id=self.argvals and self.argvals.get("slurm_job_id"),

            inside_container=True,

        )

In fluent_container.py:

    if not host_mount_path:

        if pyfluent.USE_FILE_TRANSFER_SERVICE:

            host_mount_path = pyfluent.USER_DATA_PATH

        else:

            host_mount_path = pyfluent.EXAMPLES_PATH

Is this self-consistent?

@hpohekar
Copy link
Collaborator

hpohekar commented May 15, 2024

In fluent_container.py:

Instead of handling host_mount_path on pyfluent.USE_FILE_TRANSFER_SERVICE we are using file_transfer_service to handle it now.

In container_launcher.py:

We are passing file_transfer_service=self.file_transfer_service to FluentConnection to kill the gRPC remote FTS at the time of Fluent exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants