You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
create_launcher() is ignoring unsupported arguments with no warnings
create_launcher() isn't set up to be callable on its own and results in errors about missing arguments when it should not
SlurmLauncher is defined differently from the other launchers currently, and is just ignoring unsupported arguments with no warnings, just looking at the __init__() and the reason for this should be evident. Moved to: Make the Slurm launcher interface uniform with other launchers #2832
@hpohekar if we passed an invalid argument like container=True to create_launcher() it would just be completely ignored in the way that the code is currently set up. You've just identified another issue in the current implementation, that is also resolved by this suggestion. In the way I am suggesting here, it would be identified as an invalid argument that was passed to the launcher methods.
On top of that, create_launcher() isn't really set up to be callable on its own (just tried), if you're trying to launch a Fluent container for example you'd have to provide the entire list arguments that _process_invalid_args() checks for non-standalone launches, otherwise it fails. We'd have to do additional work to properly expose create_launcher() if that is the intention (regardless of my suggestion here).
Note also that the SlurmLauncher seems to be defined differently from the other launchers currently, and is just ignoring unsupported arguments with no warnings or anything of the sort.
The text was updated successfully, but these errors were encountered:
Summary of issues:
create_launcher()
is ignoring unsupported arguments with no warningscreate_launcher()
isn't set up to be callable on its own and results in errors about missing arguments when it should not. Moved to: Make the Slurm launcher interface uniform with other launchers #2832SlurmLauncher
is defined differently from the other launchers currently, and is just ignoring unsupported arguments with no warnings, just looking at the__init__()
and the reason for this should be evidentMore details:
#2826 (comment)
#2826 (comment)
The docstrings imply that the above approach should work for
create_launcher()
:pyfluent/src/ansys/fluent/core/launcher/standalone_launcher.py
Lines 3 to 13 in c23aab7
Also:
#2826 (comment)
The text was updated successfully, but these errors were encountered: