Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to read input snapshots from memory, rather than disk #107

Closed
EDCarman opened this issue Aug 14, 2023 · 1 comment 路 Fixed by #123
Closed

Add option to read input snapshots from memory, rather than disk #107

EDCarman opened this issue Aug 14, 2023 · 1 comment 路 Fixed by #123
Assignees
Labels
enhancement New features or code improvements

Comments

@EDCarman
Copy link
Collaborator

馃摑 Description of the feature

Add option to read input snapshots from memory, rather than disk

For much the same reasons why we may prefer output snapshots in memory, rather than disk, we should consider providing input snapshots from memory. This will reduce disk I/O in cases where we may connect multiple models, all with vector inputs and outputs.

馃挕 Steps for implementing the feature

One potential implementation would be to modify the TbRom._reduce_field_input() method and replace the snapshot_filepath argument with a general snapshot argument that could be a string or Path, to read from disk, or an array or list of vec values.
Optionally add a on_disk: bool to explicitly indicate to treat the input as a vector or Path.

If on_disk, read the binary file as before. If not, skip reading and use the vector directly (convert list to np.ndarray?)

馃敆 Useful links and references

No response

@EDCarman EDCarman added the enhancement New features or code improvements label Aug 14, 2023
@lboucin
Copy link
Collaborator

lboucin commented Sep 7, 2023

  • Implementation size:
    S

  • Priority:
    medium, there is a customer workflow which could directly benefit from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants