fix(module: Select) bind value change lock, tags and labels fix, overlay reposition #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for exception when label is a property with getter only
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
=========================================
- Coverage 6.38% 6.36% -0.02%
=========================================
Files 439 439
Lines 25074 25141 +67
=========================================
Hits 1600 1600
- Misses 23474 23541 +67
Continue to review full report at Codecov.
|
zxyao145
pushed a commit
to zxyao145/ant-design-blazor
that referenced
this pull request
Mar 20, 2021
…rlay reposition (ant-design-blazor#1191) * fix(module:select) _setLabel not needed for non-tags fix for exception when label is a property with getter only * fix(module:select): bind-Value lock if changed outside component * fix(module:Select): overlay reposition SelectContent resize
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
…rlay reposition (#1191) * fix(module:select) _setLabel not needed for non-tags fix for exception when label is a property with getter only * fix(module:select): bind-Value lock if changed outside component * fix(module:Select): overlay reposition SelectContent resize
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
…rlay reposition (#1191) * fix(module:select) _setLabel not needed for non-tags fix for exception when label is a property with getter only * fix(module:select): bind-Value lock if changed outside component * fix(module:Select): overlay reposition SelectContent resize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #1171
💡 Background and solution
Commit 25c3dcb
During my tests, it came out that if I had a class that the label was attached to a property that it had only a getter, then
Selectwas crashing. The source of problems was the PR #1168. The_setLabelwas prepared regardless of the type of select. The property that is attached to label needs to have a setter only forSelectMode.Tags.Commit d4e2966
Several fixes to solve #1171. The result it this:
7c7d481
Update of the overlay position was not really effective, as it was doing its updates before all the relevant changes were pushed to DOM. Adding
Task.Delay(1)solved this issue. I am not really happy with it. The other option would be maybe to use ResizeObserver but there might be a problem with browser compatibility.Other condierations:
All operations done in mehtods
EvaluateValueChangedOutsideComponentandEvaluateValuesChangedOutsideComponentare basically needed only whenValueandValuesare changed outside of the component. I imagine this is going to be a much less often scenario in comparison to when they are changed by the component. At this stage, when values are changed by the component, the aforementioned methods are not necessary. This is mostly a performance issue when dealing with multiple/tags mode. But it probably would be beneficial to have some kind of a way to generate a hash or some other way to be able to compare if values were changed internally or externally. If external change is detected, then run the evaluation methods.📝 Changelog
☑️ Self Check before Merge