Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List / ListItem 修改建议 #220

Closed
warmhug opened this issue Sep 5, 2016 · 11 comments
Closed

List / ListItem 修改建议 #220

warmhug opened this issue Sep 5, 2016 · 11 comments
Assignees
Milestone

Comments

@warmhug
Copy link
Contributor

warmhug commented Sep 5, 2016

功能缺失

  • 目前只有最左/最右结构,正常情景应该是左中右都要有、并且像其中的左中、中右、左右形式都支持。
  • listItem 的之间的分割线 divider、目前只有一种这样的
    image
    , 希望支持 longdivider 和 nodivider (Material Design)

参考:https://onsen.io/v2/docs/js/ons-list-item.html#modifiers

API 修改建议

  • thumb =》 avatar
  • extra =》 secondary (并支持多个)
  • List.Item.Brief 去掉
  • align 为什么不直接用 flex 的 align-items 及其值?

参考:https://material.angularjs.org/latest/api/directive/mdListItem

@pingan1927
Copy link
Contributor

之前有个issues专门讨论这个List API #63

thumb =》 avatar

这个需要好好调研下。

extra =》 secondary (并支持多个) List.Item.Brief 去掉

这两个暂时不动,改起来伤筋动骨

align 为什么不直接用 flex 的 align-items 及其值?

简化,更易理解。

@pingan1927
Copy link
Contributor

目前整个支付宝的客户端基本上都只有左右结构,设计稿也只提供这样的。个人认为没有必要搞得大而全。

divider可以好好考虑

@warmhug
Copy link
Contributor Author

warmhug commented Sep 8, 2016

左中右 结构,正是来自支付宝里新的业务需求

@pingan1927
Copy link
Contributor

先跟视觉反馈给出基准的视觉稿吧。

@chenqizheng
Copy link

希望能有左中右,像其中的左中、中右、左右形式都支持。比如多选列表或者单选列表都有可能用得到。

@warmhug
Copy link
Contributor Author

warmhug commented Sep 22, 2016

divider可以好好考虑 考虑好了吗? 现在的 list 功能真不完善

@pingan1927
Copy link
Contributor

@warmhug 先跟设计师提啊。

@pingan1927 pingan1927 added this to the next milestone Oct 9, 2016
@warmhug warmhug closed this as completed Nov 28, 2016
@ghost
Copy link

ghost commented Dec 16, 2016

建议给 List 加个控制 点击反馈的。
验证表单 => 确认信息/预定人数
其实点击的是上面的元素, 这时整个 List 应该不需要有反馈。

dsafdas

@warmhug
Copy link
Contributor Author

warmhug commented Dec 16, 2016

@motorguo 本来是添加 onClick 后的 list item 上才有点击反馈,现在这算是 bug ,下个版本修复

@ghost
Copy link

ghost commented Dec 16, 2016

@warmhug 印象中,我在 v0.9.4 还是 0.9.5 用的时候,当时不加 onClick 是不会有的。

@lock
Copy link

lock bot commented May 28, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants