Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web PopupContainer #794

Closed
rendongsc opened this issue Feb 9, 2017 · 5 comments
Closed

Add Web PopupContainer #794

rendongsc opened this issue Feb 9, 2017 · 5 comments
Assignees
Labels

Comments

@rendongsc
Copy link

本地环境

  • 运行环境及其版本:RN组件,版本1.0.0-beta.2
showPopup = () => {
    Popup.show(this.getPopupContent()
      , {
        animationType: 'slide-up', maskClosable: true,
        onMaskClose: () => { }
      }
    );
  }
  getPopupContent = () => {
    return (
      <View>
        <ImagePicker
          onChange={this.handleFileChange}
          files={this.state.files}
        />
      </View>
    );
  }

image

@paranoidjk paranoidjk added the bug label Feb 12, 2017
@paranoidjk
Copy link
Contributor

ios 10.2,Image-Picker放到 Popup里,每次setState都需要Popup hide/show一次 UI 才重新渲染

@silentcloud
Copy link
Contributor

这种场景没办法使用 Popup.show 这种 api 形式的,需要使用 lib/popup/PopupContainer 的 component 形式来自定义实现 @rendongsc

@ghost
Copy link

ghost commented Feb 17, 2017

我也遇到这个问题, 使用popup,弹出对象不能使用函数式组件(因为它自身没有状态), 必须用react.component的组件.
如何优化这个组件,可以支持函数式组件呢?

@paranoidjk paranoidjk reopened this Jun 24, 2017
@paranoidjk paranoidjk changed the title ImagePicker在Popup无法显示图片预览 补充 PopupContainer 文档 Jun 24, 2017
@paranoidjk paranoidjk added doc and removed bug RN labels Jun 24, 2017
@paranoidjk paranoidjk assigned paranoidjk and unassigned silentcloud and warmhug Jun 24, 2017
@paranoidjk
Copy link
Contributor

@silentcloud popUp web 没有提供 popupContainer, 你要改这个吗?#1479

@paranoidjk paranoidjk changed the title 补充 PopupContainer 文档 Add Web PopupContainer Jun 29, 2017
@paranoidjk paranoidjk added feature and removed doc labels Jun 29, 2017
@silentcloud
Copy link
Contributor

这个 issue 在这里跟踪吧 #1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants