Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

support Footer #31

Closed
afc163 opened this issue Jun 24, 2019 · 7 comments
Closed

support Footer #31

afc163 opened this issue Jun 24, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@afc163
Copy link
Member

afc163 commented Jun 24, 2019

现在是通过下面两种方式提供 footer:

import ProLayout, { DefaultFooter } from '@ant-design/pro-layout';

<DefaultFooter />
<ProLayout
  footerRender={((_, defaultDom) => {
    return defaultDom;
  }
/>

问题

方案

直接把 https://github.com/ant-design/ant-design-pro-layout/blob/master/src/GlobalFooter/index.tsx 对外暴露,default 内容移出。

import ProLayout, { Footer } from '@ant-design/pro-layout';

<Footer
  links={[...]}
  copyright={...}
/>

<ProLayout
  footerRender={(() => {
    return (
      <Footer
        links={[...]}
        copyright={...}
      />
    );
  }
/>

兼容性

会是一个 break change,需要升级 pro-layout 大版本,并补齐相关 API 文档和 changelog。

@afc163 afc163 added the enhancement New feature or request label Jun 24, 2019
@chenshuai2144
Copy link
Collaborator

新版本的footer 已经支持这种用法了。

<Footer
  links={[...]}
  copyright={...}
/>

需要删除默认的吗?对于用户来说总要写一次 footerRender

@afc163
Copy link
Member Author

afc163 commented Jun 24, 2019

应该暴露 Footer 而不是 DefaultFooter,不同之处是 Footer 没有默认内容。

@afc163
Copy link
Member Author

afc163 commented Jun 24, 2019

  • DefaultFooter 直接改名为 Footer 好了。
  • ProLayout 不写 footerRender 时,直接读 Footer,这个和目前一致。
  • ProLayout 在 pro.ant.design 自定义时,不要读 defaultDom(多余的),而是读 Footer,这两个是一致的。

@chenshuai2144
Copy link
Collaborator

chenshuai2144 commented Jun 24, 2019

这样就不是一个 break change 了。

我理解只要能加解决 自定义 Footer 的内容的 api,使用就会方便很多。

@omarc1492
Copy link

How can I modify this to change copyright and links?

const footerRender: BasicLayoutProps['footerRender'] = (_, defaultDom) => {
if (!isAntDesignPro()) {
return defaultDom;
}
...
footerRender={footerRender}
...

Nothing I do to pass props to footerRender is working, can you give an example?

@ms20hj
Copy link

ms20hj commented Oct 24, 2019

我这是哪里写错了?
const footerRender = () => {
return (
<Footer
links={[]}
copyright={'测试测试'}
/>
);
};

@chenshuai2144
Copy link
Collaborator

chenshuai2144 commented Dec 24, 2019

https://prolayout.ant.design/footer
可以看这里

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants