Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Issue: chinese characters present in the index.js file of the pro-table/src/Form/index.tsx #10

Closed
1 task done
ABHISHEK-KEDAR-21 opened this issue Dec 16, 2019 · 5 comments · Fixed by #38
Closed
1 task done
Assignees

Comments

@ABHISHEK-KEDAR-21
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://github.com/ant-design/pro-table/blame/master/src/Form/index.tsx

Steps to reproduce

https://github.com/ant-design/pro-table/blame/master/src/Form/index.tsx
Check the content of this file

What is expected?

It should be in english

What is actually happening?

It is in Chinese

Environment Info
antd 3.26.3
React react
System i5
Browser chrome latest
@afc163 afc163 transferred this issue from ant-design/ant-design Dec 16, 2019
@chenshuai2144
Copy link
Contributor

Before joining internationalization, I will only support Chinese
You can wait for a while

@ABHISHEK-KEDAR-21
Copy link
Author

Before joining internationalization, I will only support Chinese
You can wait for a while

Could you please provide some estimation when it will be available.
And thanks for your quick reply.

@chenshuai2144
Copy link
Contributor

@AKedar21
About a month

@beyoursun
Copy link
Contributor

@chenshuai2144 I would like to help with this.

About the placeholder,we can pass the props from columns to override it. And about buttons & collapse, we add some new props to configure it, such as searchText, resetText.

What do you think?

@chenshuai2144
Copy link
Contributor

search:{
  searchText:string
  resetText:string
  collapseRender:( collapsed)=> React.Node
}

How is this?

chenshuai2144 pushed a commit that referenced this issue Dec 25, 2019
)

* feat: wrap search buttons in a Form.Item

Closes #19

* feat: support form item props passed to the search form

Closes #10

* feat: support search buttons text config

Closes #10

* feat: remove `all` option

* docs: update readme
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants