🐛 fix: fix types due to father build error #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 Deploy PR Preview 503e872 failed. Build logs
🤖 By surge-preview |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
## [3.4.6](v3.4.5...v3.4.6) (2023-09-15) ### 🐛 Bug Fixes * Fix types due to father lock ts version, closes [#109](#109) ([9bf726e](9bf726e))
|
🎉 This PR is included in version 3.4.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
@types/react最新(18.2.x)的返回是 ReactNode ，而之前的老版本则是返回的ReactElement。当使用 IDE 版本为ts <=5.0时， FC 使用的类型是 ts5.0 文件夹下的index.d.ts，一定会走到老版本。而 father 4.3.4 的版本加入了相应的强校验，且依赖的 ts 版本为
5.0.4，导致react 声明无法匹配，构建会报错。解决方案
将类型从
ReactNode改为ReturnType<FC>