🐛 fix: should parse textarea value and placeholder #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadCcc
changed the title
arvinxx
reviewed
Sep 14, 2022
src/parser/inputText.ts
Outdated
| const { value, placeholder } = node as HTMLInputElement; | ||
| if (!value && !placeholder) return; | ||
| const { value, placeholder } = node; | ||
| if (!value && !placeholder) { |
src/parser/inputText.ts
Outdated
| if (value) { | ||
| console.log(value) |
|
Commit 改成 gitmoji commit ？ 这样合并以后会自动发包 https://www.yuque.com/arvinxx-fe/workflow/gitmoji-commit-workflow |
MadCcc
changed the title
MadCcc
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
# [1.0.0-beta.15](v1.0.0-beta.14...v1.0.0-beta.15) (2022-09-14) ### 🐛 Bug Fixes * should parse textarea value and placeholder ([06d70ac](06d70ac)), closes [#161](#161)
|
🎉 This PR is included in version 1.0.0-beta.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
# [1.0.0](v0.4.7...v1.0.0) (2023-02-09) ### ♻ Code Refactoring * rename the symbol function ([09d0de9](09d0de9)) ### ✨ Features * input support overflow ([0ff7b55](0ff7b55)), closes [#177](#177) * support almost full css transform ([f7bb06d](f7bb06d)), closes [#148](#148) * support overflow element ([f4b017b](f4b017b)), closes [#178](#178) * support rad angle line-gradient ([9860090](9860090)), closes [#96](#96) * support rotate & clip-path ([35f6628](35f6628)), closes [#180](#180) * 优化抓取 base64 图片方法 ([07dd128](07dd128)) * 提供自定义 fetch 方法的能力 ([28ed276](28ed276)) * 新增固定宽高的能力 ([f2df2e5](f2df2e5)) ### 🐛 Bug Fixes * adjust text and svg resizing constraint ([9fc8970](9fc8970)) * fix absolute position margin parsing ([120ba39](120ba39)) * fix overflow hidden node use clipping mask ([defb941](defb941)) * fix overflow hidden node use clipping mask ([055f25d](055f25d)) * fix password input text ([c8ff928](c8ff928)) * fix placeholder parsing without css rules ([505a390](505a390)) * fix position bug due to sketch text align parsing error ([1dce98f](1dce98f)), closes [#51](#51) * fix pseudo elt style issue and add test ([5c727a3](5c727a3)) * fix resizingConstraint func and update test ([c39f843](c39f843)) * gradient parse in safari ([aa374e5](aa374e5)), closes [#185](#185) * parse linear-gradient ([90f3ed8](90f3ed8)), closes [#184](#184) * set default resizingConstraint to left and top ([f897275](f897275)) * should parse textarea value and placeholder ([06d70ac](06d70ac)), closes [#161](#161) * single child overflow should not be mask ([1acab12](1acab12)), closes [#181](#181) * try to fix babel problem ([398f825](398f825)) * 修正 textStyle 缺失导致修改文本造成报错的问题 ([1a44244](1a44244)) ### 💥 BREAKING CHANGES * rename `nodeToSketchSymbol` to nodeToSymbol
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #142