You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just saw your post on HN, and found your project very interesting. When looking through the README I noticed that you have Start() method that initializes the data structure, which confused me right away. My reaction was: "Wait, is he starting a server from the router here?". Turns out you're not, and your lib is super sane. However, I'd think renaming this method to Init() or providing a NewRouter() function that returns an initialized data structure would be much more idiomatic here!
HTH,
Felix
The text was updated successfully, but these errors were encountered:
Thanks for the comment! Yes, there is already a pull request open. The thing is that I may want to merge go-urlrouter into go-json-rest. In that case I probably won't need the constructor.
Hi,
I just saw your post on HN, and found your project very interesting. When looking through the README I noticed that you have Start() method that initializes the data structure, which confused me right away. My reaction was: "Wait, is he starting a server from the router here?". Turns out you're not, and your lib is super sane. However, I'd think renaming this method to
Init()
or providing aNewRouter()
function that returns an initialized data structure would be much more idiomatic here!HTH,
Felix
The text was updated successfully, but these errors were encountered: