Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] unable to edit action graph annotation #3

Closed
hrishikeshrt opened this issue May 30, 2023 · 1 comment
Closed

[BUG] unable to edit action graph annotation #3

hrishikeshrt opened this issue May 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@hrishikeshrt
Copy link
Collaborator

"Something went wrong"

@hrishikeshrt hrishikeshrt added the bug Something isn't working label May 30, 2023
@hrishikeshrt
Copy link
Collaborator Author

Occurring due to a combination of some factors

  • The way "existing" relations are checked
  • SQL unique index constraint on token graph table, disallowing multiple relations between same two tokens,
  • Soft delete

Current check uses a combination of (src_id, label_id, dst_id), so when (s0, l0, d0) exists and we try to remove that and add (s0, l1, d0), first will be marked for deletion, yet be there with is_deleted = True, and we check if (s0, l1, d0) exists, and upon finding out it doesn't, we try to add it. => Unique relation label for (s0, d0) violated.

Solution: Use (src_id, dst_id) to check for "existing" relations, and update label_id to the submitted one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant