Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchwork 1.3.0 crash: creates syntax error in Laravel interface. #16

Closed
Spudley opened this issue Aug 7, 2014 · 1 comment
Closed

Comments

@Spudley
Copy link
Contributor

Spudley commented Aug 7, 2014

Hi.

Nice new features in 1.3.0, but I think there's a bug in there too...

This is the output of my phpUnit test in my build system after composer bumped the patchwork version to 1.3.0:

PHP Parse error:  syntax error, unexpected '$__pwClosureName' (T_VARIABLE), expecting function (T_FUNCTION) in /var/lib/jenkins/workspace/build/vendor/laravel/framework/src/Illuminate/Support/Contracts/ArrayableInterface.php on line 3

This was working just fine in 1.2.9.

The context here is an application using the Laravel 4.2 framework. The file that is complaining about the error is a PHP interface deep inside the Laravel framework. It has no code content at all; not even any interface method definitions.

@antecedent
Copy link
Owner

Hey, thanks, and also thanks so much for the early catch :) Now it's either me that sucks at binary search, or, alternatively, it's PHP that sucks at providing standard library functions for fundamental algorithms. I guess I like these kind of questions open, heh.

Anyway, v1.3.1 should work fine. (Clear Patchwork's cache if it doesn't.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants