use const reference in SymbolTable lookup to avoid possible copy

antekpiechnik · May 17, 2012 · 29f2f9f · 29f2f9f
1 parent 1fc13f2
commit 29f2f9f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/vm/symboltable.cpp b/vm/symboltable.cpp
@@ -96,11 +96,11 @@ namespace rubinius {
     return 0;
   }
 
-  Symbol* SymbolTable::lookup(SharedState* shared, std::string str) {
+  Symbol* SymbolTable::lookup(SharedState* shared, const std::string& str) {
     return lookup(str.data(), str.size(), shared->hash_seed);
   }
 
-  Symbol* SymbolTable::lookup(STATE, std::string str) {
+  Symbol* SymbolTable::lookup(STATE, const std::string& str) {
     return lookup(str.data(), str.size(), state->hash_seed());
   }
 
@@ -125,7 +125,7 @@ namespace rubinius {
         symbols[hash] = v;
       } else {
         SymbolIds& v = entry->second;
-        for(SymbolIds::iterator i = v.begin(); i != v.end(); ++i) {
+        for(SymbolIds::const_iterator i = v.begin(); i != v.end(); ++i) {
           std::string& s = strings[*i];
 
           if(!strncmp(s.data(), str, length)) return Symbol::from_index(*i);

diff --git a/vm/symboltable.hpp b/vm/symboltable.hpp
@@ -66,8 +66,8 @@ namespace rubinius {
       return bytes_used_;
     }
 
-    Symbol* lookup(SharedState* shared, std::string str);
+    Symbol* lookup(SharedState* shared, const std::string& str);
-    Symbol* lookup(STATE, std::string str);
+    Symbol* lookup(STATE, const std::string& str);
     Symbol* lookup(STATE, const char* str, size_t length);
     Symbol* lookup(STATE, String* str);
     String* lookup_string(STATE, const Symbol* sym);