[5.0] Also need to switch to lib_catchup if in head_catchup when starting to sync #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Jan 24, 2024
spoonincode
approved these changes
Jan 25, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are starting to sync with a node then you expect to be in
lib_catchup. Need to switch tolib_catchupeven if you are inhead_catchup. Observed node not syncing when LIB was stuck in an integration test. The node would remain inhead_catchupand never switch tolib_catchup. Since thesync-fetch-spanwas set to 5, it would keep syncing the same 5 blocks and never leavehead_catchup.