Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] More robust chain_api_plugin check in producer_plugin; take 2 #2152

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[5.0] More robust chain_api_plugin check in producer_plugin; take 2 #2152

merged 2 commits into from
Jan 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 29, 2024

#2106 caused failure on hotstuff_integration branch as producer_plugin was initialized before chain_api_plugin. Search options instead of querying of appbase.

Resolves #2104

@heifner heifner added the OCI Work exclusive to OCI team label Jan 29, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Additional enhancement to configuration parsing and check for chain_api_plugin, updated to search through options to be more resilient to changes in the timing of loading plugins.
Note:end

@heifner heifner merged commit 2be6558 into release/5.0 Jan 29, 2024
29 checks passed
@heifner heifner deleted the GH-2104-find-chain_api_plugin-5.0 branch January 29, 2024 19:55
@heifner heifner mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@ericpassmore ericpassmore ericpassmore approved these changes

@spoonincode spoonincode Awaiting requested review from spoonincode

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heifner @ericpassmore @greg7mdp