[3.2] change HTTP code on exceeding http-max-bytes-in-flight-mb or http-max-in-flight-requests to 503
#2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Feb 5, 2024
greg7mdp
approved these changes
Feb 5, 2024
This was referenced Feb 5, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4xx response codes are for errors caused by the client where 5xx is for errors on the server side. The server exceeding its configured resource quota should be a 5xx error not a 4xx error. Change this from 429 to 503 (which is what it was in 2.0, fwiw). A 5xx error in this condition makes it easier for failover tooling, among other things. Resolves #2129