[5.0] improve reliability of http_plugin_unit_tests
via port workaround
#2229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons, sometimes when
http_plugin_test_fixture
is destroyedhttp_plugin
'slistener
s are not destroyed despitehttp_plugin
itself being destroyed. When this occurs the port thatlistener
was listening on gets tied up for the remainder ofhttp_plugin_unit_tests
causing failures for the remaining test cases.It's not clear to me why this is occurring. I suspect either some
static
somewhere or something I don't expect holdinglistener
'sshared_ptr
.In the mean time just don't reuse the same port numbers among all the different test cases. It is rather curious that the
valid_category_addresses
test case already avoided 8888 that the priorhttp_plugin_unit_tests
test case used.