Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] improve reliability of http_plugin_unit_tests via port workaround #2229

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

spoonincode
Copy link
Member

For unknown reasons, sometimes when http_plugin_test_fixture is destroyed http_plugin's listeners are not destroyed despite http_plugin itself being destroyed. When this occurs the port that listener was listening on gets tied up for the remainder of http_plugin_unit_tests causing failures for the remaining test cases.

It's not clear to me why this is occurring. I suspect either some static somewhere or something I don't expect holding listener's shared_ptr.

In the mean time just don't reuse the same port numbers among all the different test cases. It is rather curious that the valid_category_addresses test case already avoided 8888 that the prior http_plugin_unit_tests test case used.

@spoonincode spoonincode merged commit cafe5a3 into release/5.0 Feb 9, 2024
29 checks passed
@spoonincode spoonincode deleted the http_ut_ports_50 branch February 9, 2024 00:09
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Improve http plugin unit tests by avoiding dangling listeners.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants