Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download example in Readme #52

Closed
phlippieb opened this issue Oct 14, 2016 · 4 comments
Closed

Update download example in Readme #52

phlippieb opened this issue Oct 14, 2016 · 4 comments

Comments

@phlippieb
Copy link

The Readme provides the following example for saving objects to file:

let destination: NSURL = FileManager.defaultManager().URLsForDirectory(.DocumentDirectory, inDomains: .UserDomainMask)[0]
amazonS3Manager.download(at: "myFolder/fileName.jpg", to: destination)

This code doesn't compile in Swift 3. The file manager API is outdated, and it seems that the download method does not accept an NSURL as its to: parameter. Please update with a working example.

Been using this library for a while and really like it. Migrating to Swift 3 is just a PITA in general. Cheers!

@AnthonyMDev
Copy link
Owner

Thanks for the kind words and the heads up! I
l'll get to this soon.

@saqibomer
Copy link

Any update on this issue?

@AnthonyMDev
Copy link
Owner

This has been fixed. The README will now show the correct way to download files using the latest version of Alamofire.

@phlippieb
Copy link
Author

@AnthonyMDev Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants