Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Crashlytics" does not conform to protocol "CrashlyticsProtocol" #1

Closed
humblehacker opened this issue May 5, 2016 · 5 comments
Closed
Assignees

Comments

@humblehacker
Copy link
Contributor

humblehacker commented May 5, 2016

I'm finally getting around to trying this out, but I'm running into this issue compiling:

"Crashlytics" does not conform to protocol "CrashlyticsProtocol"
CrashlyticsRecorder.CrashlyticsProtocol:10:17: 
Protocol requires function 'recordError(_:withAdditionalUserInfo:)' with type '(NSError, withAdditionalUserInfo: [String : AnyObject]?) -> ()'

I suspect the Crashlytics class has changed since this code was written. Are you still using this in your own code? And if so, do you have an updated version?

@AnthonyMDev
Copy link
Owner

What version of Crashlytics are you using? I've not seen this error yet. I've also been informed that Crashlytics now supports dynamic frameworks, so this library shouldn't be needed anymore.

@humblehacker
Copy link
Contributor Author

Thanks for the reply. I'm on the latest, 3.7.0. I haven't heard about Crashlytics/Fabric being provided as a dynamic framework. That would be great! Can you point me to any details online?

@AnthonyMDev
Copy link
Owner

I actually don't see anything about the change on their change log. To be fair, I haven't confirmed that this is true myself. It was just told to me by someone else recently.

It's likely that there was a change in the most recent version of Crashlytics that was API braking. I'll try to carve out sometime tomorrow afternoon to get this fixed. If you need it before then, a PR is always appreciated! It should be a pretty easy fix, assuming they didn't completely change all of their API's.

@AnthonyMDev AnthonyMDev self-assigned this May 10, 2016
@AnthonyMDev
Copy link
Owner

@humblehacker I've looked into it, and this library is still working just fine for me. There is no changes that are stopping it from conforming.

Have you followed the directions in the README? You do need to include the CrashlyticsAdapter.swift file in your project.

@AnthonyMDev
Copy link
Owner

@humblehacker Can you please confirm that you have included the adapter in your code and the problem persists? If I don't hear back from you, I'm going to close this issue.

Thanks

AnthonyMDev pushed a commit that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants