Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize editor theme creation #47

Open
salim-b opened this issue Oct 15, 2020 · 0 comments
Open

Modularize editor theme creation #47

salim-b opened this issue Oct 15, 2020 · 0 comments

Comments

@salim-b
Copy link
Contributor

salim-b commented Oct 15, 2020

Since we now provide two different editor themes which still share most of their CSS rules, I think it would make a lot of sense to separate/modularize the CSS code (e.g. into multiple files). This would have the following benefits:

  • Providing the help pane styling I wrote for Tomorrow Night Bright (rscodeio) for the default rscodeio, too.

  • Easily allow to add new editor theme variants enlarging the available range of syntax highlighting styles. There seems to be some demand for this.

  • Avoiding any unwanted deviations between rscodeio's different editor theme variants and easing future maintenance of this package.

I'm everything else than skilled in "CSS land", so I don't know much about more sophisticated tools/technologies like PostCSS or SCSS/Sass. But I have a feeling that it might make a lot of sense to e.g. directly switch to a Sass pipeline.

Addendum: I just noticed there's the sass R package from RStudio that allows to compile Sass to CSS from within R. It also provides a short introduction into Sass.

Addendum 2: It might be beneficial to examine how the rsthemes package solves this. Its author was apparently crazy enough to expose all relevant CSS selectors in the rsthemes::rstheme() function assisting in the creation of new editor themes.

@anthonynorth What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant