Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

[DON'T MERGE] Start of port to Qt5 #18

Closed
wants to merge 1 commit into from
Closed

[DON'T MERGE] Start of port to Qt5 #18

wants to merge 1 commit into from

Conversation

waddlesplash
Copy link

There are some things that need to be done before this can be merged:

  • Get a build of Qt5 that contains the QWebPrinter class (other than that this should work)
  • Test it vigorously
  • Cleanup the code
  • Make sure it works with Qt4 (should, because I used a bunch of #ifdefs)

If someone with more knowledge of wkhtml2pdf (and a Qt5+QWebPrinter build) could finish this off, that would be great.

@astroo
Copy link

astroo commented Sep 12, 2013

Can you tell how to get the QT5 with QWebPrinter?
My own build of qt5 seems doesn't have that class.

@waddlesplash
Copy link
Author

QWebPrinter is a custom class that's part of wkhtmltopdf. You have to build your own Qt.

@astroo
Copy link

astroo commented Sep 16, 2013

Thanks for your response. But i can't find the declaration of QWebPrinter class in wkhtmltopdf, and can't find it in webkit shipped with QT5.

@mdesign83
Copy link

@astroo
Copy link

astroo commented Sep 16, 2013

Yes i find it now. But the branch here (http://qt.gitorious.org/qt/antializes-qt/source/08c134d0b8a541cbb7ab6396baff1f07fe437d98:src/3rdparty/webkit/Source/WebKit/qt/Api) is for QT4.8.4. So i guess i need to extract the source of QWebPrinter and add it to QT5.

@waddlesplash
Copy link
Author

Closing. The diff will stay here if someone wants to reference this as I have no plans to continue working on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants