Fix background glitch

[andreamazz]

This should fix #14 although it might need to be documented in the readme since this happens also when you have a fluid view in a tab. Once the user switches tabs and goes back to the one with the fluid we should stop and restart the animation as well. In this case the UIApplicationWillResignActiveNotification and UIApplicationDidBecomeActiveNotification won't do the trick and we need to use for instance viewWillAppear/Disappear.

What do you think?

[antiguab]

Hey! Thanks for all the help. We should definitely use UIApplicationWillResignActiveNotification and UIApplicationDidBecomeActiveNotification. Any reason you put it in BAViewController and not the BAFluidView (since the methods only affect UI elements)? Instead of using viewWillAppear in the viewController, I used willMoveToWindow in the BAFluidView. Figured this way we can avoid having the developer deal with it. Let me know what you think! branch w/ proposed fix

[andreamazz]

I exposed that because the same issue happens if you have a tab controller. Let's say that tab 1 has a fluid view, when the users switches to tab 2 and back to tab 1 you'll find the wave animation glitched. That can be fixed by starting and stopping the animation in viewWillAppear: and viewWillDisappear:, catching UIApplicationWillResignActiveNotification won't work.

[antiguab]

Right! So my solution (instead of viewWillAppear:) was to do this in BAFluidView:

- (void)willMoveToWindow:(UIWindow *)newWindow {
    if(newWindow == nil){
        //the view is being removed
        [self stopAnimation];
        return;
    }

    //the view is being added
    [self startAnimation];
}

Which results in this:

Thoughts?

[andreamazz]

Brilliant!

[andreamazz]

Ok, tested it on Gulps and it works great. The API is also cleaner, the startAnimation call is no longer required 👍