Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Windows when typing a second prompt! #15

Open
JustAHippo opened this issue Mar 17, 2023 · 8 comments
Open

Error on Windows when typing a second prompt! #15

JustAHippo opened this issue Mar 17, 2023 · 8 comments

Comments

@JustAHippo
Copy link

image
I'm not really sure what causes this as I don't know C++

@JustAHippo
Copy link
Author

This actually only occurs for debug! Whoops. still an issue though. I just built with release since i've been accidentally building wrong this whole time. It's so much faster. Will keep open cuz maybe it's something?

@InfernalDread
Copy link

@JustAHippo

Hey, I have been trying to get this to work on Windows myself, but I am not sure how. If it is no bother, could you make a tutorial?

Thank you for your time!

@mcmonkey4eva
Copy link

@InfernalDread I have PR'd a Windows install guide to the readme, you can check it here #26

@InfernalDread
Copy link

@mcmonkey4eva That is great! Thank you very much! I will try it soon!

@txomon
Copy link

txomon commented Mar 17, 2023

the segfault might be related to #18 just in case

@InfernalDread
Copy link

Just wanted to update, the suggested windows installation tutorial that @mcmonkey4eva has supplied has worked for me as well. Once again, thank you!

@Castaa
Copy link

Castaa commented Mar 19, 2023

anyone find a fix for this in Windows 10?

This seems to be a source level bug. Seemly relying on how the compiler handles a back() call on an empty vector?

@Castaa
Copy link

Castaa commented Mar 21, 2023

I tracked down the empty std::vector back() call assert generated by a 2nd input prompt.

The issue in is line 1078 in chat.cpp. embd is an empty vector and the code is attempting to assign a value to an element which doesn't exist.
if (embd.back() == 2 ) {

I put a empty vector check for the variable embd before this line executed called to avoid the assert but doing it causes every other input prompt to be ignored.

if (embd.size() == 0) { embd.push_back(2); }

Maybe someone with more time or savvy can figure out why this bug only appears when running in Windows (10?). I'm using the latest version of Visual Studio 2022 (17.5.2) to compile it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants