-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim Layers to Images #5
Comments
That means taking a slightly different approach -- duplicating the document, trimming, exporting, and jumping back in history --, but I don't think it should be too hard to implement. No. It will be slower, of course, but we'll consider it (without taking slices into account). Funny thing -- the built-in script has this option only for PNG; we'd support it for all formats if at all. |
bump |
@patrickkidd, I believe that this issue cannot be solved while maintaining the same performance. One of the biggest performance hits that the Adobe script has is the trimming of layers. Currently if you're looking for layer trimming I recommend you use the built-in script. As @skjorn also mentioned, we could most certainly do it, but again our script will take a severe hit. If however we can find a way to make a faster method of trimming during export then we'll be sure to implement it as an option. The purpose of our script is not to meet feature equivalence with Adobe but rather be a simple and quick script for use-cases that are also simpler. |
I was thinking something along the lines: if a trimming option is set (or something other that requires destructive changes), the document would duplicate and run a slow variant. The majority of use cases would not be affected and it would provide a higher level of automation. I see no harm in that. I'd have to do that anyway if we are to support any of the pending features. It's just not a priority right now. I have to prefer payed work, but I might get around to implement this some time. (Or someone else.) |
Of course. Yes, I would only see it as an additional option, not a replacement. I also wouldn't prioritize it (especially over paid work) because I feel that the performance hit would be significant enough to just use the Adobe script. |
Just a side note: Bear in mind that the Adobe script is glitchy. There are actually a few bugs fixed in our script that they don't handle properly. Aside from other useful improvements (like an ability to cancel, for example). I would use our script over theirs any time and recommend it earnestly. As to the performance, it's true. If every layer was to be trimmed. If only all layers combined are trimmed (once), which is a valid option, it would be faster. Even if every layer is trimmed, but not duplicated into a separate document, it would still run much better than the built-in script. The question is if it can be pulled with history tricks. |
Implemented. I didn't have a chance to test it on anything newer than CS2, so if you run into any issues, let me know. |
The built in script has the option to automatically trim the generated images. It's to hard to implement this on this fast script?
Great work, thanks!
The text was updated successfully, but these errors were encountered: