Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation #87

Open
seppo0010 opened this issue Oct 28, 2011 · 6 comments
Open

Keyboard navigation #87

seppo0010 opened this issue Oct 28, 2011 · 6 comments

Comments

@seppo0010
Copy link
Contributor

In lists navigate with j/k and vote with a/z.

@seppo0010
Copy link
Contributor Author

@antirez let me know if you approve the feature and I can work on a pull request.

@antirez
Copy link
Owner

antirez commented Oct 28, 2011

Hi! I like it, thank you for your contribution :)

p.s. I'm trying to implement the new stuff, especially related to karma, in a way that is easy to enable/disable them, please if you can add something like a KeyboardNavigation constant to app_conf.rb so that it is possible to switch this on/off as needed.

@seppo0010
Copy link
Contributor Author

@antirez let me know if there's something you don't like about the pull request to adjust.

@antirez
Copy link
Owner

antirez commented Oct 30, 2011

Merged! Thank you, great work.

IMHO only two things that can be improved are:

  • show help on '?'
  • on comments for some reason the 'selection' box is smaller than the comment itself. Probably related to some HTML bug in the code itself?

@seppo0010
Copy link
Contributor Author

@antirez
what do you think about adding shortcuts to browse each section?
e.g.: g then t opens top, g then l opens latest.

That's widely used in google reader and seems comfortable for me.

@fcambus
Copy link
Collaborator

fcambus commented May 4, 2013

@seppo0010 Merged your fixes, everything works flawlessly now, thanks! :)

Adding shortcuts to browse each section sounds like a great idea, not sure what @antirez thinks about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants