CLUSTER GETKEYSINSLOT: avoid overallocating.

Close #3911.
redis · Jul 11, 2017 · e1b8b4b · e1b8b4b
1 parent 5bd46d3
commit e1b8b4b
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/cluster.c b/src/cluster.c
@@ -4380,6 +4380,11 @@ void clusterCommand(client *c) {
             return;
         }
 
+        /* Avoid allocating more than needed in case of large COUNT argument
+         * and smaller actual number of keys. */
+        unsigned int keys_in_slot = countKeysInSlot(slot);
+        if (maxkeys > keys_in_slot) maxkeys = keys_in_slot;
+
         keys = zmalloc(sizeof(robj*)*maxkeys);
         numkeys = getKeysInSlot(slot, keys, maxkeys);
         addReplyMultiBulkLen(c,numkeys);