Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no header guards in some headers #2543

Closed
tfarina opened this issue Apr 26, 2015 · 1 comment
Closed

There is no header guards in some headers #2543

tfarina opened this issue Apr 26, 2015 · 1 comment

Comments

@tfarina
Copy link

tfarina commented Apr 26, 2015

Like in version.h, ziplist.h.

Isn't good to have them?
antirez added a commit that referenced this issue Apr 29, 2015
@antirez
Add header guard for ziplist.h
9e7f39d 
As suggested in #2543.
@antirez
Copy link
Contributor

antirez commented Apr 29, 2015

Hello, thanks, added for ziplist.h. For version.h it is explicitly avoided to make this a single easy to parse line, so you can fetch it with curl http://download.redis.io/redis-stable/src/version.h and easily parse it with a shell script or whatever. Thanks.

@antirez antirez closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antirez @tfarina