Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVALSHA is logged as EVAL in SLOWLOG #3403

Closed
stefanolczak opened this issue Jul 21, 2016 · 1 comment · Fixed by #8006
Closed

EVALSHA is logged as EVAL in SLOWLOG #3403

stefanolczak opened this issue Jul 21, 2016 · 1 comment · Fixed by #8006

Comments

@stefanolczak
Copy link

stefanolczak commented Jul 21, 2016

It seems there is a bug that is caused by replication script cache. When calling EVALSHA of script that doesn't exist in replication script cache the command used for script call is rewritten to EVAL for slave propagation. After the script call is done the rewritten command is pushed to SLOWLOG. When there are no slaves connected and the AOF is disabled the replication script cache is flushed every 1 second so many script calls will be logged wrongly. So when examining SLOWLOG entries it can be confusing what commands are used especially when you are debugging script performance like me;) In other hand is it really necessary to update the replication script cache if there are no slaves connected?

@madolson madolson linked a pull request Nov 10, 2020 that will close this issue
@madolson
Copy link
Contributor

Thanks for reporting this, looks like a more general issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants